Skip to content

fix(py): correct ConstString JSON encoding #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

fix(py): correct ConstString JSON encoding #2325

merged 1 commit into from
Jun 10, 2025

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Jun 10, 2025

No description provided.

@ss2165 ss2165 requested a review from a team as a code owner June 10, 2025 09:37
@ss2165 ss2165 requested a review from zrho June 10, 2025 09:37
@ss2165 ss2165 force-pushed the push-wxyuyplvoozk branch from cfff955 to becc6b9 Compare June 10, 2025 09:38
@ss2165 ss2165 enabled auto-merge June 10, 2025 09:39
@ss2165 ss2165 added this pull request to the merge queue Jun 10, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (1ad450f) to head (becc6b9).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2325      +/-   ##
==========================================
- Coverage   82.08%   82.08%   -0.01%     
==========================================
  Files         241      241              
  Lines       43891    43890       -1     
  Branches    39728    39728              
==========================================
- Hits        36027    36026       -1     
  Misses       5883     5883              
  Partials     1981     1981
Flag Coverage Δ
python 85.46% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into main with commit 9649a48 Jun 10, 2025
26 checks passed
@ss2165 ss2165 deleted the push-wxyuyplvoozk branch June 10, 2025 09:45
@hugrbot hugrbot mentioned this pull request Jun 10, 2025
Merged
ss2165 added a commit that referenced this pull request Jun 24, 2025
@ss2165
fix(py): correct ConstString JSON encoding (#2325)
9d039d0
ss2165 added a commit that referenced this pull request Jul 3, 2025
@ss2165
fix(py): correct ConstString JSON encoding (#2325)
325168b
@hugrbot hugrbot mentioned this pull request Jul 3, 2025
Merged
ss2165 pushed a commit that referenced this pull request Jul 3, 2025
@hugrbot
chore(release/hugr-py-0.12.3): release hugr-py 0.12.3 (#2404)
551e1dc 
🤖 I have created a release *beep* *boop*
---


##
[0.12.3](hugr-py-v0.12.2...hugr-py-v0.12.3)
(2025-07-03)


### Features

* add toposort to HUGR-py
([#2367](#2367))
([ba8988e](ba8988e))
* **core, llvm:** add array unpack operations
([#2339](#2339))
([74b25aa](74b25aa)),
closes [#1947](#1947)
* **py:** Helper methods to get the neighbours of a node
([#2370](#2370))
([1ed6440](1ed6440))


### Bug Fixes

* Escape html-like labels in DotRenderer
([#2383](#2383))
([c7a43a6](c7a43a6))
* Fixed invalid extension name in test.
([#2319](#2319))
([fbe1d9c](fbe1d9c))
* **py:** correct ConstString JSON encoding
([#2325](#2325))
([325168b](325168b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
ss2165 pushed a commit that referenced this pull request Jul 3, 2025
@hugrbot @ss2165
chore(release/hugr-py-0.12.3): release hugr-py 0.12.3 (#2404)
5d6ce87 
🤖 I have created a release *beep* *boop*
---


##
[0.12.3](hugr-py-v0.12.2...hugr-py-v0.12.3)
(2025-07-03)


### Features

* add toposort to HUGR-py
([#2367](#2367))
([ba8988e](ba8988e))
* **core, llvm:** add array unpack operations
([#2339](#2339))
([74b25aa](74b25aa)),
closes [#1947](#1947)
* **py:** Helper methods to get the neighbours of a node
([#2370](#2370))
([1ed6440](1ed6440))


### Bug Fixes

* Escape html-like labels in DotRenderer
([#2383](#2383))
([c7a43a6](c7a43a6))
* Fixed invalid extension name in test.
([#2319](#2319))
([fbe1d9c](fbe1d9c))
* **py:** correct ConstString JSON encoding
([#2325](#2325))
([325168b](325168b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot pushed a commit that referenced this pull request Jul 25, 2025
@hugrbot @aborgna-q
chore(main): release hugr-py 0.13.0rc1 (#2302)
2ac643d 
🤖 I have created a release *beep* *boop*
---


##
[0.13.0rc1](hugr-py-v0.12.2...hugr-py-v0.13.0rc1)
(2025-07-24)


### ⚠ BREAKING CHANGES

* Lowering functions in extension operations are now encoded as binary
envelopes. Older hugr versions will error out when trying to load them.
* **py:** `EnvelopeConfig::BINARY` now uses the model binary encoding.
`EnvelopeFormat.MODULE` is now `EnvelopeFormat.MODEL`.
`EnvelopeFormat.MODULE_WITH_EXTS` is now
`EnvelopeFormat.MODEL_WITH_EXTS`
* hugr-model: Symbol has an extra field
* Renamed the `Any` type bound to `Linear`
* The model CFG signature types were changed.
* Added `TypeParam`s and `TypeArg`s corresponding to floats and bytes.
* `TypeArg::Sequence` needs to be replaced with `TypeArg::List` or
`TypeArg::Tuple`
* FuncDefns must be moved to beneath Module.
`Container::define_function` is gone, use
`HugrBuilder::module_root_builder`; similarly in hugr-py
`DefinitionBuilder` (`define_function` ->
`module_root_builder().define_function`). In hugr-llvm, some uses of

### Features

* Add `BorrowArray` extension
([#2395](#2395))
([782687e](782687e))
* Add `MakeError` op ([#2377](#2377))
([909a794](909a794)),
closes [#1863](#1863)
* add toposort to HUGR-py
([#2367](#2367))
([34eed34](34eed34))
* Add Visibility to FuncDefn/FuncDecl.
([#2143](#2143))
([5bbe0cd](5bbe0cd))
* Added float and bytes literal to core and python bindings.
([#2289](#2289))
([e9c5e91](e9c5e91))
* **core, llvm:** add array unpack operations
([#2339](#2339))
([a1a70f1](a1a70f1)),
closes [#1947](#1947)
* Detect and fail on unrecognised envelope flags
([#2453](#2453))
([5e36770](5e36770))
* Export entrypoint metadata in Python and fix bug in import
([#2434](#2434))
([d17b245](d17b245))
* Expose `BorrowArray` in `hugr-py`
([#2425](#2425))
([fdb675f](fdb675f)),
closes [#2406](#2406)
* include generator metatada in model import and cli validate errors
([#2452](#2452))
([f7cedb4](f7cedb4))
* Names of private functions become `core.title` metadata.
([#2448](#2448))
([4bc7f65](4bc7f65))
* No nested FuncDefns (or AliasDefns)
([#2256](#2256))
([214b8df](214b8df))
* Non-region entrypoints in `hugr-model`.
([#2467](#2467))
([7b42da6](7b42da6))
* Open lists and tuples in `Term`
([#2360](#2360))
([292af80](292af80))
* **py:** enable Model as default BINARY envelope format
([#2317](#2317))
([f089931](f089931))
* **py:** Helper methods to get the neighbours of a node
([#2370](#2370))
([bb6fa50](bb6fa50))
* **py:** Use SumValue serialization for tuples
([#2466](#2466))
([f615037](f615037))
* Rename 'Any' type bound to 'Linear'
([#2421](#2421))
([c2f8b30](c2f8b30))
* Split `TypeArg::Sequence` into tuples and lists.
([#2140](#2140))
([cc4997f](cc4997f))
* Standarize the string formating of sum types and values
([#2432](#2432))
([ec207e7](ec207e7))
* Use binary envelopes for operation lower_func encoding
([#2447](#2447))
([2c16a77](2c16a77))


### Bug Fixes

* Ensure SumTypes have the same json encoding in -rs and -py
([#2465](#2465))
([7f97e6f](7f97e6f))
* Escape html-like labels in DotRenderer
([#2383](#2383))
([eaa7dfe](eaa7dfe))
* Export metadata in Python
([#2342](#2342))
([7be52db](7be52db))
* Fix model export of `Opaque` types.
([#2446](#2446))
([3943499](3943499))
* Fixed bug in python model export name mangling.
([#2323](#2323))
([041342f](041342f))
* Fixed bugs in model CFG handling and improved CFG signatures
([#2334](#2334))
([ccd2eb2](ccd2eb2))
* Fixed export of `Call` and `LoadConst` nodes in `hugr-py`.
([#2429](#2429))
([6a0e270](6a0e270))
* Fixed invalid extension name in test.
([#2319](#2319))
([c58ddbf](c58ddbf))
* Fixed two bugs in import/export of function operations
([#2324](#2324))
([1ad450f](1ad450f))
* map IntValue to unsigned repr when serializing
([#2413](#2413))
([26d426e](26d426e)),
closes [#2409](#2409)
* Order hints on input and output nodes.
([#2422](#2422))
([a31ccbc](a31ccbc))
* **py:** correct ConstString JSON encoding
([#2325](#2325))
([9649a48](9649a48))
* StaticArrayVal payload encoding, improve roundtrip checker
([#2444](#2444))
([1a301eb](1a301eb))
* stringify metadata before escaping in renderer
([#2405](#2405))
([8d67420](8d67420))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Release-As: 0.13.0rc1

---------

Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrho zrho zrho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ss2165 @zrho