[WNMGDS-3185] Upgrade to React 18.3.1 #3433
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-ryan-nava-pbc
added
Impacts: Core
* Updates to latest `@testing-library/react` and removes `@testing-library/react-hooks` dep * removes reference to outdated package in jest config * swaps out references to `@testing-library/react-hooks` with ones to `@testing-library/react` * fixes failing autocomplete test with a pause * removes outdated references to test-utils in webpack config * simplifies jest config preact settings * replaces references to `react-dom/test-utils` with `@testing-library/react` * replaces `react-dom/test-utils` references to `@testing-library/react` and uses jest's modern fakeTimers * update jest config * update `@testing-library/user-event` to latest * updates Autocomplete unit tests based on v14 of `@testing-library/user-event` * invoke userEvent and allow for custom settings in web component renderer * updates Accordion Item unit tests * refactors userEvent invoking in autocomplete * refactors choice and choice list tests * updates date field unit tests * updates dialog tests * specifically listen for the `Escape` key in addition to the keyCode because v14 of `@testing-library/user-event` only passes along `key` * addresses drawer and dialog tests * refactors drawer tests * refactors dropdown tests * refactors filter chip tests * refactors help drawer and month picker tests * updates skip nav and review unit tests * tabs and idleTimeout unit test updates * removes `sleep` helper utilities from unit tests * updates mask unit tests * refactors ds-tooltip unit test * refactors Tabs unit test * refactors p/react TextField unit tests * removes a resolved TODO * refactors tooltip unit tests * refactors vertical nav unit tests * resolves failing preact unit tests * resolve `ds-dropdown` test * removes eslint overrides in docs project for now * respond to PR feedback
* upgrades packages for gatsby v5 * package updates * [for now] removes repeatable content import from markdown files * updates eslint * Updates graphql query based on warning from gatsby build tools * creates new helper for sending view event * upgrades to latest mdx plugin; updates queries and content renderer component * updates packages used in docs site * Use ES Modules format for gatsby config files * updates MdxQuery types * fixes missing slug * fixes `code` and `pre` formatting * updates markdown files (WNMGDS-3285) https://mdxjs.com/docs/what-is-mdx/#interleaving * prettier and interleaving inconsistencies * fixes missing slug info
Resolves eslint errors and adjusts linting rules to allow for destructuring objects
* fixes `react-app` examples * updates astro package dependencies;
* Initial commit * Remove stray console log and one line of whitespace * Clean up Layout component * Uninstall react helmet * Remove react helmet reference in base package-lock * Remove unnecessary params. * Switch to LocationInterface * Hardcode site origin base url in SEO to fix missing location.origin in Head context. * Use dynamic window.location.origin in SEO * Adds ogUrl variable
* Removes default props for `Alert` and updates docs * Removes default props for `Autocomplete` and updates Docs * Removes default props for `Button` and updates Docs * Removes default props for `ChoiceList` * Removes default props for `Drawer` and updates docs * Removes default props for `SvgIcon` * Updates docs for svgicon * Removes default props for `Label` and updates docs * Removes default props for `Pagination` and updates docs * Removes default props for `Review` and updates docs * Removes default props for `Spinner` and updates docs * Removes default props for `Table` and `TableCell` and updates docs * Removes default props for `TabPanel` * Removes default props for `TextField` and updates docs * Removes default props for `Tooltip` and updates docs * Removes default props for `VerticalNav` and `VerticalNavItem` and updates docs * Removes default props for ds-healthcare-gov `Header` and updates docs * removes default props for `FilterDialog` * removes default props for `InlineLinkLists` * removes default props for ds-healthcare-gov `Logo` * Updates docs * Addresses jest warning for timings when running unit tests * Updates how ds-tooltip default props work * Fixing placement error in popper js --------- Co-authored-by: jack-ryan-nava-pbc <[email protected]>
* removes default props from `ThirdPartyExternalLink` * Removes default props from Accordion Item * removes default props from HelpDrawer
* Adds relative linking to component headings * Replaces repeated text with `ColorGuidanceGuidelines` component * leverage gatsby's `location` data from pages * include analytics boolean * remove data attribute lacking a clear purpose * address typecheck failures
4 tasks
…/react-18-upgrade
* Upgrade storybook packages, fix peer dependency issue with an mdx package * Fix prop table formatting by removing HTML tags from example descriptions * Update package lock * Remove unnecessary storybook addon from config * Adds snapshots
* Remove unneeded ref prop from prop tables * Hide internal prop from external documentation * Hide internal facing props * Show children for accordion item props table * Replace hide-prop with ignore directive and clean up label story * Show children prop as required * Update snapshots
Bump version to 2.4.0, and remove override.
Publish - @cmsgov/[email protected] - @cmsgov/[email protected] - @cmsgov/[email protected] - @cmsgov/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the feature branch that all subsequent React 18 related upgrades will build off of.
Steps:
How to test
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.