Add a transform/validator that checks for files on a default path.#698
Merged
phlptp merged 7 commits intoCLIUtils:mainfrom Jan 31, 2022
Merged
Add a transform/validator that checks for files on a default path.#698phlptp merged 7 commits intoCLIUtils:mainfrom
phlptp merged 7 commits intoCLIUtils:mainfrom
Conversation
Collaborator
Author
|
This will need a couple more test cases and some docs before merging but wanted to see what @henryiii and Firefly35 thought of this alternative. |
Collaborator
|
This looks good, works within the existing infrastructure, and can be expanded to look in several locations (like |
henryiii
reviewed
Jan 30, 2022
henryiii
reviewed
Jan 30, 2022
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
henryiii
approved these changes
Jan 31, 2022
phlptp
force-pushed
the
FileOnDefaultPathTransform
branch
from
7d5eaa8 to
afc19b8
Compare
github-actions
bot
added
the
needs changelog
Collaborator
|
Corrected, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #684 and closes #682. It add a transform/validator that checks for a file and on a default path.
This if used with a config ptr can be used to add a default path, or any number of default paths for that matter.
I think it has the same capabilities as #684 without adding any additional API calls and adding a new validator which may have other uses as well.