add an option to validate optional arguments like in a vector.#668
Merged
henryiii merged 5 commits intoCLIUtils:mainfrom Jan 28, 2022
Merged
add an option to validate optional arguments like in a vector.#668henryiii merged 5 commits intoCLIUtils:mainfrom
henryiii merged 5 commits intoCLIUtils:mainfrom
Conversation
Collaborator
Author
|
For example can now parse properly withour error |
henryiii
approved these changes
Jan 28, 2022
Collaborator
henryiii
left a comment
There was a problem hiding this comment.
I worry about increasing the already quite large API surface, but this looks good. I'm guessing the reason (other than backward compatibility) that this would not be on by default or always on and not a setting would be the error messages are likely poorer with it on?
Collaborator
Author
|
Having it on by default could lead to some confusing results, and it does add computation and the main reason it is needed is symmetry with vector positional arguments in the API, and for situations with positionals and vector arguments. |
…an resolve some issues with separating positionals from vector arguments
e15507c to
d56c5cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can resolve some issues with separating positionals from vector arguments