Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1141 1149 +8
Branches 233 237 +4
=====================================
+ Hits 1141 1149 +8
Continue to review full report at Codecov.
|
Collaborator
Author
|
@lambdafu , let me know how this works (and maybe the other two PRs, too) :) |
Contributor
|
Looks good! I'll implement this in a larger program and see if there are any issues remaining. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the interests of solving #36, this PR refactors the way extras are handled. The implementation:
parseno longer returns a vector (not well supported anyway, for example withCLI11_PARSEremaining()andremaining_size(), which provide access into the unparsed options. They support a "recurse" bool flag that causes them to collect all subcommand arguments, too. They are not "reversed".allow_extrasandprefix_commandare now valid on subcommands, and inherit the setting from the parent upon creation (like the other options)Oddities that remain:
Will need to maybe add more tests, and needs docs and changelog.