Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 3353 3354 +1
=====================================
+ Hits 3353 3354 +1
Continue to review full report at Codecov.
|
phlptp
reviewed
Dec 3, 2019
phlptp
reviewed
Dec 3, 2019
cbachhuber
force-pushed
the
clang-tidy-fixes
branch
from
14c02b7 to
cd7dae2
Compare
phlptp
reviewed
Dec 4, 2019
phlptp
reviewed
Dec 4, 2019
Collaborator
|
The CI should be checking clang-tidy (though it might have been lost during the transition of formatting to GitHub Actions). |
Collaborator
|
I remember getting some PR's where the clang-tidy checks were triggered recently so I think it is still working, but I was also under the impression that was only checking a pretty limited subset of the clang-tidy checks and specifically ones where there was an auto fix that was possible. |
phlptp
approved these changes
Dec 4, 2019
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the clang-tidy issues in Option.hpp.