Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1726 1744 +18
=====================================
+ Hits 1726 1744 +18
Continue to review full report at Codecov.
|
c8e495e to
cb59af8
Compare
78d8c73 to
a728e26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully will fix several recent issues by properly restructuring how parsing works inside subcommands. Each action is called recursively on subcommands, rather than during an "overall" parse. This way, each phase is complete before the next starts.
Count with no arguments now works like subcommands, and is an int. Listing a subcommand twice should increment the count twice, in theory, and could be used to call the subcommand recursive parts in order.
Todo:
Issues this may resolve: #176, #168 (better fix). It does not directly fix #173, but might be a step in the right direction.