Skip to content

Adding new parse layout#178

Merged
henryiii merged 5 commits intomasterfrom
breakup_parse
Jan 2, 2019
Merged

Adding new parse layout#178
henryiii merged 5 commits intomasterfrom
breakup_parse

Conversation

@henryiii
Copy link
Copy Markdown
Collaborator

@henryiii henryiii commented Nov 12, 2018

This hopefully will fix several recent issues by properly restructuring how parsing works inside subcommands. Each action is called recursively on subcommands, rather than during an "overall" parse. This way, each phase is complete before the next starts.

Count with no arguments now works like subcommands, and is an int. Listing a subcommand twice should increment the count twice, in theory, and could be used to call the subcommand recursive parts in order.

Todo:

  • Add tests for new behavior (Issue authors are welcome to suggest tests)
  • Add a few unit tests for the new count feature, at least.
  • Possibly look at using parsed subcommands to do subparses in order (later, and maybe for options too)

Issues this may resolve: #176, #168 (better fix). It does not directly fix #173, but might be a step in the right direction.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 12, 2018

Codecov Report

Merging #178 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #178   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1726   1744   +18     
=====================================
+ Hits         1726   1744   +18
Impacted Files Coverage Δ
include/CLI/Option.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba85eb...a728e26. Read the comment docs.

@henryiii henryiii changed the title WIP: Adding new parse layout Adding new parse layout Jan 2, 2019
@henryiii henryiii merged commit c3d8d4a into master Jan 2, 2019
@henryiii henryiii deleted the breakup_parse branch January 2, 2019 21:16
@henryiii henryiii added this to the v1.7 milestone Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accumulation of errors for a better message Required + config files

1 participant