Conversation
Now use type_name and type_size instead of set_custom_option.
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1669 1682 +13
=====================================
+ Hits 1669 1682 +13
Continue to review full report at Codecov.
|
b30dcc3 to
c655679
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishing off #128 . Summary:
set_on Option'stype_name,default_str, anddefault_val. Deprecatedset_type_name, removed the others.set_custom_optionwithtype_nameandtype_sizeinstead ofset_custom_option. Methods now properly returnthis.set_type_name_fnalso has theset_removed.set_from App'sfailure_message,footer,callback, andname. The final threeset_*names are deprecated, whileset_failure_messageis simply removed.The way #128 would look after this PR:
That makes a repeating option of size 2. This syntax was chosen over multiple arguments because it is clearer to read and doesn't require a special version for
type_name_fn.