fix edge case with config files pointer #1199
Merged
phlptp merged 4 commits intoCLIUtils:mainfrom Aug 29, 2025
Merged
Conversation
…default and no config file provided.
Collaborator
Author
|
this edge case could also apply if someone was manipulating and running an option callback outside of the app. The fix resolves both situations. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 17 17
Lines 4546 5180 +634
Branches 0 1064 +1064
===========================================
+ Hits 4546 5180 +634 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generating a seg fault if no default and no config file provided.
Fixes #1197
This was likely introduced by the combination of fixes for some issues with the config parsing and some updates to the as method a while back. This edge case on the handling of the config pointer with as was not overlooked in the earlier testing.