Can add lexical_cast overloads constrained with enable_if#1021
Can add lexical_cast overloads constrained with enable_if#1021phlptp merged 1 commit intoCLIUtils:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 17 17
Lines 4546 4557 +11
Branches 0 971 +971
==========================================
+ Hits 4546 4557 +11 ☔ View full report in Codecov by Sentry. |
|
New Codacy issue is a false positive: This class member is, in fact, used.
|
…ts, or requirements.
7eeb13d to
f407d2c
Compare
|
I think I am ok with this. I want to try it out in a few other contexts just to check a few things. |
|
Any updates here? |
|
I think this seems fine, waiting on @phlptp to check whatever he was going to check. |
|
@phlptp any updates here? |
|
Sorry I am on vacation right now, didn't get a chance to explore before leaving. If you want to merge it I think it is fine, and If I find any issues later I will make some fixes. Otherwise it will be a couple weeks yet. |
|
OK will ping again in May |
|
Played with this in a few other applications and tests, no issues came up in compilation or testing so I am going to merge it. |
Also works for overloads constrained with concepts or requirements.
Previously this wasn't working, which is a problem if you want to hook some external serialization framework into CLI11 without painstakingly going through all the types that said external framework supports.
This PR is related to #908.