Skip to content

Pep8 Love, New Parameters, and Start of an OO API #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

lojikil
Copy link

@lojikil lojikil commented Jun 22, 2014

I've made this PR a bit bigger than I initially meant to, but here's what I've done:

  • I've added two parameters, gzip and apikey to most methods, which passes them "up" the chain eventually to query. A bit more configurable than gzip_default.
  • I've done some minor PEP8 massaging, and done a bit of testing with frosted
  • I've started creating an OO version of the API; URLQuery is started, the rest should flow from there. It's separate from the original api, but obviously modeled on it.
  • Added a pip requirements.txt to help with installation for those who use pip.

My next steps are two fold:

  • Tests! I've started stubbing out some, but there's more to do there. It'd be nice if every procedure & method had at least one test.
  • Convert the responses from URLQuery into objects to be hydrated based on API calls.

Still, for initial work, it's a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant