use unmarshalbinary

[aviau]

It looks line net/url only implements UnmarshalBinary:

• https://golang.org/pkg/net/url/#URL.UnmarshalBinary

Should the toml package use it too?

BTW, I have opened a bug on golang: golang/go#25705

Even if this is a bug with golang, maybe it wouldn't be bad to try UnmarshalBinary when UnmarshalText is not present.

[arp242]

What's the practical benefit of supporting this? What problems does it solve?

[sorcix]

I've encountered this today when I tried to load a config file with:

type Config struct {
    Address *url.URL
}

The workaround is having a config struct with a string field and parsing the URL later. If the package would have supported UnmarshalBinary it would have worked right away.

[sorcix]

Looks like the stdlib encoding/json package also doesn't support this, so it may not be worth it.

https://go.dev/play/p/8XfmdkXecHm

[arp242]

Yeah dunno, I need to look at it. At least I understand why it's being asked.