Skip to content

Conversation

@allaboutevemirolive
Copy link
Contributor

@allaboutevemirolive allaboutevemirolive commented Nov 14, 2023

I've cut the Clippy warnings in half, dropping from 57 to 28. The remaining warnings likely require changes to variable names.

@BurntSushi

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really agree with most of these changes. I don't feel terribly strong about most of them, but generally prefer to not accept most of these. This is why I don't have Clippy setup to run. (I realize I could pick and choose which lints I want to enable, but this is a lot of work to do across the number of repos I maintain and just ultimately isn't worth it for me.)

I marked the changes that I agree with.

@allaboutevemirolive
Copy link
Contributor Author

allaboutevemirolive commented Nov 14, 2023

Is this okay with you? @BurntSushi

Regarding your opinion on Clippy, I will take note of that. Currently, I am studying string searching related to the unstable search function in the Rust compiler and came across your great works, specifically Aho-Corasik's :).

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurntSushi BurntSushi merged commit cd400ad into BurntSushi:master Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants