-
Notifications
You must be signed in to change notification settings - Fork 109
Resolving clippy warning #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BurntSushi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really agree with most of these changes. I don't feel terribly strong about most of them, but generally prefer to not accept most of these. This is why I don't have Clippy setup to run. (I realize I could pick and choose which lints I want to enable, but this is a lot of work to do across the number of repos I maintain and just ultimately isn't worth it for me.)
I marked the changes that I agree with.
|
Is this okay with you? @BurntSushi Regarding your opinion on Clippy, I will take note of that. Currently, I am studying string searching related to the unstable search function in the Rust compiler and came across your great works, specifically Aho-Corasik's :). |
BurntSushi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I've cut the Clippy warnings in half, dropping from 57 to 28. The remaining warnings likely require changes to variable names.
@BurntSushi