Skip to content

Deprecate MaximumOAFlowRate #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Deprecate MaximumOAFlowRate #396

merged 3 commits into from
Sep 30, 2021

Conversation

JieXiong9119
Copy link
Contributor

See proposal.
Follow-up to #395 and address #296.

@JieXiong9119 JieXiong9119 self-assigned this Sep 29, 2021
@JieXiong9119 JieXiong9119 linked an issue Sep 29, 2021 that may be closed by this pull request
Copy link
Contributor

@macintoshpie macintoshpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Comment on lines +162 to +166
<auc:DuctSystems>
<auc:DuctSystem ID="DuctSystem-1">
<auc:MaximumOAFlowRate>5000</auc:MaximumOAFlowRate>
</auc:DuctSystem>
</auc:DuctSystems>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks for testing!!!

Comment on lines +60 to +62
<auc:eGRIDSubregionCodes>
<auc:eGRIDSubregionCode>AKGD</auc:eGRIDSubregionCode>
</auc:eGRIDSubregionCodes>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅✅✅✅✅✅

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

@nllong nllong merged commit dd1711e into develop-v3 Sep 30, 2021
@nllong nllong deleted the deprecate/maximumoaflowrate branch September 30, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DuctSystem/MaximumOAFlowRate Rename
3 participants