Add eGRIDSubregionCodes #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JieXiong9119
added
Non-breaking Change
feature
macintoshpie
suggested changes
Sep 13, 2021
BuildingSync.xsd
Outdated
| </xs:annotation> | ||
| <xs:complexType> | ||
| <xs:sequence> | ||
| <xs:element name="eGRIDSubregionCode"> |
There was a problem hiding this comment.
I think we need a maxOccurs="unbounded" here, assuming we want to allow more than one
There was a problem hiding this comment.
There was a problem hiding this comment.
I thought the xs:sequence element implies “unbounded" - if not, I should add maxOccurs="unbounded".
Similarly, do we need to add minOccurs="1" to make it valid?
There was a problem hiding this comment.
@nllong sorry which line is that? It's just linking to a file diff
The default value for both the minOccurs and the maxOccurs attributes is 1
To allow multiple child elements under eGRIDSubregionCodes
macintoshpie
approved these changes
Sep 17, 2021
| </xs:annotation> | ||
| <xs:complexType> | ||
| <xs:sequence> | ||
| <xs:element name="eGRIDSubregionCode" maxOccurs="unbounded"> |
JieXiong9119
added
enhancement
feature
This was referenced Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See proposal.
Resolve #358 and #383