Feat/translation #348
Merged
Feat/translation #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nllong
requested changes
May 21, 2021
spec/validation_spec.rb
Outdated
| # and point schemaLocation to it instead | ||
| schema_doc = Nokogiri::XML(File.read('BuildingSync.xsd')) | ||
|
|
||
| GEOJSON_XSD_PATH = 'geojson.xsd' |
There was a problem hiding this comment.
Isn't this supposed to be GBXML_XSD_PATH and not GEOJSON?
There was a problem hiding this comment.
whoops, not sure how that happened, I'll get that fixed
There was a problem hiding this comment.
terminology leaking from other projects :(
| ``` | ||
| Then transform your file(s) with | ||
| ```bash | ||
| xsltproc [-o <output>] <stylesheet> <file> [<file> ...] |
| </xsl:template> | ||
|
|
||
| <!-- Map "Repair leaks / seal ducts" to "Repair leaks in ducts" --> | ||
| <xsl:template match="auc:MeasureName[. = 'Repair leaks / seal ducts']"> |
These files are no longer used
macintoshpie
force-pushed
the
feat/translation
branch
from
3004b72 to
9088d45
Compare
|
@aviveiros11 or @JieXiong9119 can one of you also take a look at this? |
|
I just tested it on pc. Working fine! |
JieXiong9119
approved these changes
May 24, 2021
nllong
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
BuildingSync v3 is being developed with breaking changes from v2
What does this PR do?
Creates the translation file for transforming breaking v3 changes from v2 bsync instance documents.
This includes translations for the breaking changes that were already merged into v3:
/with spaces #335How should this be manually tested?
See validation_spec.rb. You can run locally and see the translated v2 file in spec/output
What are the relevant tickets?
#347