Skip to content

test: add test for duplicate element names #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

macintoshpie
Copy link
Contributor

What does this PR do?

Adds test which checks for duplicate element names

How should this be manually tested?

NA

What are the relevant tickets?

BuildingSync/project-tracker#21

@macintoshpie macintoshpie requested review from nllong, aviveiros11 and JieXiong9119 and removed request for nllong April 12, 2021 16:23
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done. I like that we can slowly fix the dupes!

@macintoshpie macintoshpie merged commit 3f1aecc into develop Apr 13, 2021
@macintoshpie macintoshpie deleted the test/no-name-duplicates branch April 13, 2021 17:26
@JieXiong9119 JieXiong9119 added feature Adding new functionality to BuildingSync Non-breaking Change labels Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality to BuildingSync Non-breaking Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants