Add TotalRoofArea #307
Add TotalRoofArea #307
Conversation
JieXiong9119
requested review from
aviveiros11,
corymosiman12,
macintoshpie,
nllong and
yan130
JieXiong9119
added
feature
BuildingSync.xsd
Outdated
| @@ -796,6 +796,18 @@ | |||
| </xs:simpleContent> | |||
| </xs:complexType> | |||
| </xs:element> | |||
| <xs:element name="TotalExteriorRoofArea" minOccurs="0"> | |||
There was a problem hiding this comment.
Wondering if we should use TotalRoofArea instead? I don't have a preference, was wondering if there might have been a reason we added Exterior to the wall area one, but if it is necessary for roofs.
There was a problem hiding this comment.
I think total roof area is concise and better. Is there a non-exterior/interior roof anywhere?
There was a problem hiding this comment.
I think TotalRoofArea is good.
BuildingSync.xsd
Outdated
| </xs:annotation> | ||
| <xs:complexType> | ||
| <xs:simpleContent> | ||
| <xs:extension base="xs:decimal"> |
There was a problem hiding this comment.
maybe make this as a non negative decimal type (we might need to add this as a base type). see the BoundedDecimalZeroToOne for something similar.
There was a problem hiding this comment.
- create new simple type for nonNegativeDecimal, something like:
<xs:simpleType name="BoundedDecimalZeroToOne">
<xs:restriction base="xs:decimal">
<xs:minInclusive value="0"/>
<xs:maxInclusive value="1"/>
</xs:restriction>
</xs:simpleType>- Use
TotalRoofArea
Else looks good!
1. Changed `TotalExteriorRoofArea` to `TotalRoofArea`. 2. Created new simple type for `nonNegativeDecimal` and applied for the added element.
Done! Please check it again. |
|
Perfect. Yeah, I think renaming would be good. |
JieXiong9119
changed the title
|
@JieXiong9119 -- can you resolve the conflicts on this one? |
See proposal
Implementation in schema added