Skip to content

Add new measure for install electrical storage #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 16, 2020
Merged

Add new measure for install electrical storage #280

merged 4 commits into from
Dec 16, 2020

Conversation

nllong
Copy link
Member

@nllong nllong commented Dec 16, 2020

Addresses #274

markborkum
markborkum reviewed Dec 16, 2020
View reviewed changes
markborkum
markborkum requested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks.

Please revert the change to the XSD file. It should be in a separate pull request.

@nllong nllong requested a review from markborkum December 16, 2020 15:24
@nllong nllong merged commit 99981ef into develop Dec 16, 2020
@nllong nllong deleted the feat/274-add-install-exec-storage branch December 16, 2020 15:48
@nllong nllong added Schema: Measures Update to measures Non-breaking Change enhancement feature Adding new functionality to BuildingSync and removed enhancement labels Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markborkum markborkum Awaiting requested review from markborkum

1 more reviewer

@corymosiman12 corymosiman12 corymosiman12 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
feature Adding new functionality to BuildingSync Non-breaking Change Schema: Measures Update to measures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nllong @markborkum @corymosiman12