Skip to content

Update annotations for data dictionary #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 16, 2020
Merged

Update annotations for data dictionary #278

merged 6 commits into from
Dec 16, 2020

Conversation

nllong
Copy link
Member

@nllong nllong commented Dec 16, 2020

This PR addresses #273.

  • Update the annotations of the measure technology categories.
  • Upgrade dependencies
  • Update generate_data_dictionary script to add in a nice display name for the tech category

markborkum
markborkum reviewed Dec 16, 2020
View reviewed changes
markborkum
markborkum requested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks.

Should the formatting change in the XSD file be part of this pull request?

macintoshpie
macintoshpie approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@macintoshpie macintoshpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

@nllong nllong merged commit 27980b9 into develop Dec 16, 2020
@nllong nllong deleted the docs/273-TechCat-annotations branch December 16, 2020 15:47
@nllong nllong added Schema: Documentation Update to BuildingSync's documentation/annotations Non-breaking Change labels Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markborkum markborkum markborkum requested changes

+1 more reviewer

@macintoshpie macintoshpie macintoshpie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Non-breaking Change Schema: Documentation Update to BuildingSync's documentation/annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nllong @markborkum @macintoshpie