Skip to content

Add Air/WaterInfiltrationNotes to Air/WaterInfiltrationSystem #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2020

Conversation

macintoshpie
Copy link
Contributor

No description provided.

@macintoshpie macintoshpie added Schema: Systems Update to systems Non-breaking Change STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync labels Sep 8, 2020
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to BuildingSync.xsd look good, thanks.

Please update references to "STD 211" in proposal document to match project style.

Copy link
Contributor

@corymosiman12 corymosiman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with mark - else looks good!

Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks.

@macintoshpie macintoshpie force-pushed the feat/infiltration-system-notes branch from d7d26b7 to d157da8 Compare September 11, 2020 20:39
@macintoshpie macintoshpie merged commit 9e56ecc into develop Sep 11, 2020
@macintoshpie macintoshpie deleted the feat/infiltration-system-notes branch September 11, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-breaking Change Schema: Systems Update to systems STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants