Skip to content

Add choice for multiple auc:WallIDs within auc:Side #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Add choice for multiple auc:WallIDs within auc:Side #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee1912a
doc(proposals): add proposal for auc:WallIDs
macintoshpie Sep 8, 2020
eca7b36
refactor(schema): add choice for multiple WallIDs
macintoshpie Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 32 additions & 22 deletions BuildingSync.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1109,28 +1109,16 @@
</xs:simpleContent>
</xs:complexType>
</xs:element>
<xs:element name="WallID" minOccurs="0">
<xs:annotation>
<xs:documentation>ID number of the wall type associated with this side of the section.</xs:documentation>
</xs:annotation>
<xs:complexType>
<xs:sequence>
<xs:element name="WallArea" minOccurs="0">
<xs:annotation>
<xs:documentation>Exposed, above-grade, opaque wall area of this type. (ft2)</xs:documentation>
</xs:annotation>
<xs:complexType>
<xs:simpleContent>
<xs:extension base="xs:decimal">
<xs:attribute ref="auc:Source"/>
</xs:extension>
</xs:simpleContent>
</xs:complexType>
</xs:element>
</xs:sequence>
<xs:attribute name="IDref" type="xs:IDREF" use="required"/>
</xs:complexType>
</xs:element>
<xs:choice>
<xs:element ref="auc:WallID" minOccurs="0"/>
<xs:element name="WallIDs">
<xs:complexType>
<xs:sequence>
<xs:element ref="auc:WallID" minOccurs="0" maxOccurs="unbounded"/>
</xs:sequence>
</xs:complexType>
</xs:element>
</xs:choice>
<xs:element name="WindowID" minOccurs="0">
<xs:annotation>
<xs:documentation>ID number of the window type associated with this side of the section.</xs:documentation>
Expand Down Expand Up @@ -17520,4 +17508,26 @@
<xs:enumeration value="High"/>
</xs:restriction>
</xs:simpleType>
<xs:element name="WallID">
<xs:annotation>
<xs:documentation>ID number of the wall type associated with this side of the section.</xs:documentation>
</xs:annotation>
<xs:complexType>
<xs:sequence>
<xs:element name="WallArea" minOccurs="0">
<xs:annotation>
<xs:documentation>Exposed, above-grade, opaque wall area of this type. (ft2)</xs:documentation>
</xs:annotation>
<xs:complexType>
<xs:simpleContent>
<xs:extension base="xs:decimal">
<xs:attribute ref="auc:Source"/>
</xs:extension>
</xs:simpleContent>
</xs:complexType>
</xs:element>
</xs:sequence>
<xs:attribute name="IDref" type="xs:IDREF" use="required"/>
</xs:complexType>
</xs:element>
</xs:schema>
13 changes: 13 additions & 0 deletions proposals/2020/Allow Multiple Walls for Side.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Allow Multiple Walls for Side

## Overview

This proposal is to modify the `auc:Side` to allow an unbounded number of `auc:Wall` IDs to be referenced

## Justification

Currently you can only reference one wall ID for each `auc:Side`. This is an issue if a side of a building is composed of more than one wall type.

## Implementation

This proposal suggests the schema creates a choice between a single `auc:WallID` (how things currently are), or `auc:WallIDs` which contains an unbounded number of wall IDs. This is non-breaking and the former choice could be dropped in the next major release.