[VULN-118] Stop forwarding MongoDB TLS file paths on Cloud#19244
Merged
Conversation
MongoIntegration forwarded tlsCertificateKeyFile/tlsCAFile from the datasource config directly into the MongoDB driver as filesystem paths, regardless of environment. The builder UI only exposes these fields when SELF_HOSTED is true, but that gating was UI-only — the backend still accepted and used them on Cloud if present in the request payload, which is unsafe on a shared, multi-tenant server. buildMongoClientOptions() now only forwards these fields into the driver when environment.SELF_HOSTED is true, enforcing server-side what the UI already implied. Self-hosted behavior is unchanged.
jvcalderon
force-pushed
the
fix/vuln-118-read-oracle
branch
from
July 21, 2026 15:04
d1ec665 to
e58aa31
Compare
jvcalderon
marked this pull request as ready for review
July 21, 2026 15:06
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
melohagan
approved these changes
Jul 21, 2026
jvcalderon
enabled auto-merge
July 22, 2026 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MongoIntegrationforwardedtlsCertificateKeyFile/tlsCAFilefrom the datasource config directly into the MongoDB driver as filesystem paths, regardless of environment. The builder UI only exposes these fields whenSELF_HOSTEDis true, but that gating was UI-only — the backend still accepted and used them on Cloud if present in the request payload, which is unsafe on a shared, multi-tenant server.buildMongoClientOptions()now only forwards these fields into the driver whenenvironment.SELF_HOSTEDis true, enforcing server-side what the UI already implied. Self-hosted behavior is unchanged — that deployment model's server filesystem belongs to the customer, so the same concern doesn't apply there.Addresses
Launchcontrol
Fixed a security issue affecting Budibase Cloud related to MongoDB datasource TLS configuration. Self-hosted behavior is unaffected.