Skip to content

fix: can miss sharepoint name on partial falure#19200

Merged
Dakuan merged 1 commit into
masterfrom
fix/sharepoint-connection-name
Jul 14, 2026
Merged

fix: can miss sharepoint name on partial falure#19200
Dakuan merged 1 commit into
masterfrom
fix/sharepoint-connection-name

Conversation

@Dakuan

@Dakuan Dakuan commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes SharePoint knowledge sources sometimes persisting without their site name or URL when the connect-time site listing omits the selected site. The selected site metadata is now submitted with the connection request and used as a fallback preventing the loading placeholder or raw SharePoint site ID from becoming the permanent display name.


Summary by cubic

Prevents SharePoint knowledge sources from saving without a site name or URL by sending the selected site’s metadata with the connection request and using it as a fallback when the site listing is missing.

  • Bug Fixes

    • Builder now submits a site object (id, name, webUrl) instead of siteId.
    • Server accepts site, prefers current listing data, and falls back to submitted metadata to avoid placeholder or raw ID names.
    • Validation and types updated; adds tests for fallback behavior and empty site id rejection.
  • Migration

    • Update clients to send site: { id: string, name?: string, webUrl?: string } instead of siteId.

Written for commit 34a71a6. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@deanhannigan deanhannigan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice one! 🚀

@Dakuan
Dakuan merged commit afc4646 into master Jul 14, 2026
36 checks passed
@Dakuan
Dakuan deleted the fix/sharepoint-connection-name branch July 14, 2026 15:05
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants