fix: can miss sharepoint name on partial falure#19200
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes SharePoint knowledge sources sometimes persisting without their site name or URL when the connect-time site listing omits the selected site. The selected site metadata is now submitted with the connection request and used as a fallback preventing the loading placeholder or raw SharePoint site ID from becoming the permanent display name.
Summary by cubic
Prevents SharePoint knowledge sources from saving without a site name or URL by sending the selected site’s metadata with the connection request and using it as a fallback when the site listing is missing.
Bug Fixes
siteobject (id, name, webUrl) instead ofsiteId.site, prefers current listing data, and falls back to submitted metadata to avoid placeholder or raw ID names.Migration
site: { id: string, name?: string, webUrl?: string }instead ofsiteId.Written for commit 34a71a6. Summary will update on new commits.