Secfix/sso takeover#19173
Merged
Merged
Conversation
|
📚 No documentation changes were needed for this PR. |
Contributor
There was a problem hiding this comment.
1 issue found and verified against the latest diff
Confidence score: 2/5
- In
packages/types/src/documents/global/config.ts,allowUnverifiedEmailLinkingis defined in the config types but appears not to be mapped throughfetchStrategyConfig, so the runtime strategy may ignore this flag and allow unintended OIDC account-linking behavior if merged as-is. Wire the field throughfetchStrategyConfigand add a focused test that verifies persisted config and runtime config stay in sync before merging.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/types/src/documents/global/config.ts">
<violation number="1" location="packages/types/src/documents/global/config.ts:88">
P0: The `allowUnverifiedEmailLinking` field is added to both `OIDCInnerConfig` and `OIDCStrategyConfiguration`, but `fetchStrategyConfig` (the function that maps from the stored config to the runtime strategy config) does not propagate it. The destructuring on the input and the return object both omit this field, so it will be silently dropped at runtime — the feature will have no effect.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Contributor
There was a problem hiding this comment.
1 issue found across 8 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
melohagan
requested changes
Jul 8, 2026
melohagan
requested changes
Jul 8, 2026
melohagan
left a comment
Collaborator
There was a problem hiding this comment.
Just noticed a possible null-pointer, otherwise looks ok
melohagan
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mitigates -> GHSA-hp6v-6jw7-gv2f