Feature/api connectors automations#18978
Conversation
- Rotate '+' icon when add step panel is open (matches app screen pattern) - Toggle add step panel on repeated button clicks - Close add step panel with Escape key - Fix toolbar shifting when step settings panel opens by making side panels overlay absolutely instead of participating in grid layout
|
Documentation Changes Added
Actions
If neither actions are selected, on PR close/merge the docs branch in ReadMe will remain open. |
melohagan
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 23 files
Confidence score: 3/5
- In
packages/builder/src/components/integration/APIEndpointViewer.svelte,selectedDatasourceIdprioritizingqueryDatasourceIdoveractiveDatasourceIdmeans datasource changes for existing queries can be ignored, and with connection edits now enabled forrestTemplateIdqueries this can silently snap selections back to an older datasource. This is a concrete user-facing regression risk in query editing flows—update the selection precedence/sync logic and verify with an edit-path test before merging.
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
|
||
| $: isAddStepPanelOpen = !!$automationStore.actionPanelBlock | ||
|
|
||
| const openAddStepPanel = () => { |
There was a problem hiding this comment.
This is not opening anymore. Should that be called toggle?
| @@ -1 +1 @@ | |||
| <script> | |||
| > | ||
| <div class="item-body"> | ||
| <img | ||
| width={17.5} |
There was a problem hiding this comment.
How come this is not 18px in here?
|
|
||
| await fireEvent.click(screen.getByText("Open API explorer")) | ||
|
|
||
| await waitFor(() => { |
There was a problem hiding this comment.
Not important, but this pattern might cause false positives, as the empty state is the default one. So it can be initially empty and then to be populated on some part of the livecycle
| // The step input properties | ||
| $: inputData = automationStore.actions.getInputData(block) | ||
| $: fieldKey = "query" | ||
| $: restTemplateId = (inputData as Record<string, any> | undefined) |
There was a problem hiding this comment.
We should type the inputData, instead of casting it in here. Or even better, typing automationStore.actions.getInputData
| // Source for current query, if any | ||
| $: dataSource = | ||
| restSources?.find(ds => ds._id === targetSource) || restSources?.[0] | ||
| // Source for current query, if any. Do not default to the first REST source: |
| saveAndClose={true} | ||
| settingsLocked={true} | ||
| connectionPopoverPortalTarget=".spectrum" | ||
| connectionPopoverZIndex={9999} |
There was a problem hiding this comment.
This crazy z-index is usually not a good pattern, as the code end up with a mess of them. Could this not be solved by positioning the components in the right order?
2 participants
Description
Adds connector steps to automations, combining existing REST Templates with the API Request step.
Addresses
Screenshots
Launchcontrol
Adds connectors to automations.
Improved automation toolbar UX with icon rotation, toggle behavior, Escape key support, and fixed panel positioning. Connector steps now open the side panel directly instead of a modal.
Summary by cubic
Adds connector steps to automations by combining REST Templates with the API Request step, improving the step picker, and keeping the API explorer in the side panel for a faster, smoother build flow. Connector steps now open the side panel directly and streamline building API automations.
New Features
restTemplateIdand opens the API explorer in-panel.APIEndpointViewer,QuerySelect, andConnectionSelectfilter to the chosen template; passrestTemplateId, restrict connection choices when needed, and support custom popover portal/z-index.savedQueryon save-and-close.Bug Fixes
APIEndpointViewerdatasource selection and avoid auto-opening the connection menu when a connection is already selected.Written for commit 735fa68. Summary will update on new commits.