Skip to content

[Security] Block active content attachment uploads#18763

Merged
PClmnt merged 3 commits into
masterfrom
codex/fix-attachment-active-content
May 12, 2026
Merged

[Security] Block active content attachment uploads#18763
PClmnt merged 3 commits into
masterfrom
codex/fix-attachment-active-content

Conversation

@PClmnt
Copy link
Copy Markdown
Contributor

@PClmnt PClmnt commented May 11, 2026

Description

Apply active-content attachment checks to all upload paths, not only public-user uploads, so authenticated users cannot store browser-executable attachment content through builder or table upload endpoints.

Addresses

App Export

  • N/A

Screenshots

  • N/A, backend upload validation fix only.

Launchcontrol

Attachment uploads now reject active web content for all users.


Summary by cubic

Block active-content attachment uploads across all endpoints to prevent browser-executable files from being stored. Applies to both public and authenticated uploads to mitigate stored XSS.

  • Bug Fixes
    • Enforce extension, MIME, and content-based checks on all upload paths (builder and table) for every user.
    • Expand blocked types: extensions js, jse, mjs, wasm; MIME application/javascript, text/javascript, application/wasm.
    • Update tests to assert 400 rejection for builder uploads and authenticated table uploads.

Written for commit f4f52c1. Summary will update on new commits.

@PClmnt PClmnt marked this pull request as ready for review May 12, 2026 09:25
@PClmnt PClmnt merged commit c38e7dc into master May 12, 2026
34 checks passed
@PClmnt PClmnt deleted the codex/fix-attachment-active-content branch May 12, 2026 11:33
@github-actions github-actions Bot locked and limited conversation to collaborators May 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants