Skip to content

fix: Error rate scale #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2018
Merged

fix: Error rate scale #261

merged 1 commit into from
Aug 10, 2018

Conversation

robertleeplummerjr
Copy link
Contributor

Also go ahead and bump version and build.

A GIF or MEME to give some spice of the internet

Description

Motivation and Context

issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfies the motivation.

Also go ahead and bump version and build.
@robertleeplummerjr
Copy link
Contributor Author

brain.NeuralNetwork use percent of likelihood, brain.recurrent.RNN uses ratio of prediction (base 2 logarithm). The answer here was to simply divide the ratio so it would be closer to the scale used in brain.NeuralNetwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant