Skip to content

Command cleanup & alignment #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2023
Merged

Command cleanup & alignment #4262

merged 3 commits into from
May 24, 2023

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented May 24, 2023

Cleanup and alignment of command classes and testing.
Closes #4225.

Todo

  • Added testing coverage to all tests
  • Align/update command class code
  • Align naming (Add Commmand to their name?)

- Aligned usage of injecting through handler.
- Aligned handler return type.
- Aligned argument and arg desc format.
- Aligned lack of constructor.
@ssddanbrown ssddanbrown merged commit 4c72620 into development May 24, 2023
@ssddanbrown ssddanbrown deleted the command_cleanup branch November 8, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Clean up command classes
1 participant