Skip to content

Add popular PHP templating languages to code editor #3879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

jhit
Copy link
Contributor

@jhit jhit commented Nov 29, 2022

Smarty and Twig are two very popular PHP templating engines and might be useful to some Bookstack users too.

Smarty and Twig are two very popular PHP templating engines and might be
useful to some Bookstack users too.
@ssddanbrown
Copy link
Member

Thanks for offering this @jhit. Just to confirm, do you personally have a current desire/need to use both of these code formats within BookStack?

@jhit
Copy link
Contributor Author

jhit commented Nov 29, 2022

@ssddanbrown Hi.,
Yes, we develop e-commerce solutions based on JTL-Shop and Shopware.
We recently started to use BookStack for internal documentation and as developers a significant part of this contains code samples with both of this templating engines.
At least Twig, as part of the Symfony framework should have a large user base today.

@ssddanbrown ssddanbrown added this to the v22.11.1 milestone Nov 30, 2022
@ssddanbrown
Copy link
Member

Thanks @jhit for confirming. Just a bit too late for the next feature release, since I've wrapped that up to go out tomorrow, but I've assigned this to be in the next patch release thereafter.

@jhit
Copy link
Contributor Author

jhit commented Nov 30, 2022

No problem @ssddanbrown. I can add the change manually for the next release. In the end, it is not a huge effort :-)
Thanks for accepting the PR

@ssddanbrown ssddanbrown merged commit 559e392 into BookStackApp:development Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants