Skip to content

Refactor of item-level permission to be more intuitive #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Oct 14, 2022
Merged

Refactor of item-level permission to be more intuitive #3760

merged 19 commits into from
Oct 14, 2022

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Oct 2, 2022 •
edited
Loading

Related to #410

Also makes the item permissions view much more mobile responsive.

Todo

  • Fix existing use of permission page JavaScript (Row toggle)
  • Add interface support for selecting/adding additional roles.
  • Add new "Other Roles" option.
  • Migrate & drop existing entity permissions where restricted=0. DOCUMENT.
  • Migrate existing restricted=1 item entries with new "Other Roles" option with no permissions.
  • Drop restricted entity field.
  • Translations for strings.
  • Update "Restricted" search filter.
  • Update restricted indicator in entity details view partial.
  • Fix shelf-copy-permissions functionality.
  • Handle/warn/document removal of restricted field in API data (If exists). Not part of API data AFAICT.
  • Dark mode support check
  • Update item-permission page with new intro text.
    • Mention cascade behaviour for chapters and books?
  • Scenario test manually - Scenario Testing
  • Re-test migration from old DB content
  • Test dropping of entity-permissions on non-restricted entities upon upgrade.
  • Test migration of restricted=1 entries to new "Other Role" active entries.
  • Test PermissionApplicator@hasEntityPermission logic.
  • Test migration on MySQL container (upon dev mariadb setup)
  • Test migration on demo instance db copy.

Docs Updates

  • Update note: General advisory of significant change of entity permission application.
    • Update note: Advise that previous rows in custom permissions, with nothing selected, will not be visible since the "Everyone Else" fallback handles this instead now.
  • Update note: Inactive Entity permissions will be deleted upon upgrade.

@ssddanbrown ssddanbrown self-assigned this Oct 2, 2022
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Oct 2, 2022
@ssddanbrown ssddanbrown changed the title Refactor of item-level permission to be more intuative Refactor of item-level permission to be more intuitive Oct 2, 2022
@ssddanbrown
Cleaned up old permission JS code
b8b0afa 
Removed now unused JS entity-permissions compontent.
Updated existing permissions-table compontent to newer format.
Removed now unused translation string.
@ssddanbrown
Added user-interface for "Everyone Else" entity permission item
a03245e 
Nothing on back-end logic done to hook this new option up.
Addition of permissions for role_id=0 works out of the box, but active
"everyone else" permissions, with no priviliges, is currently not
working. Needs change of permission gen logic also.
@ssddanbrown
Added proper entity permission removal on role deletion
1df9ec9 
Added test to cover.
@ssddanbrown
Migrated entity_permissions table to new flat format
1d3dbd6 
Simplifies structure and limits content count, while allowing direct
mapping of new UI intent, where we may have entries with no permissions.
Not yet updated app logic to suit.

Tested via migrating and rolling-back, then comparing export data,
across a set of custom permission entries.
@ssddanbrown
Started code update for new entity permission format
aee0e16
@ssddanbrown
Updated joint perms. gen. to use new entity permission format
3839bf6
@ssddanbrown
Added migration to drop entity restricted field
06a7f1b
@ssddanbrown
Reorgranised permission routes into their own controller
bf59176 
Also introduced helpers for getting entities by slugs since we do it in
so many places.
@ssddanbrown
Centralised handling of permission form data to own class
ffd6a10 
Also updates show roles on permission view to just those with
permissions applied.
Fixes rounded borders for lone permission rows.
Moves "Everyone Else" handling from role to new class.
@ssddanbrown
Added interface for adding/removing roles in entity perms.
803934d
@ssddanbrown
Updated restricted usage on search and entity meta details
63056db 
Also removed now unused view.
@ssddanbrown
Removed most usages of restricted entitiy property
0f68be6
@ssddanbrown
Fixed and updated "Everyone Else" permissions handling
0fae807 
- Fixed inheriting control for new system.
- Tested copying shelf permissions to books.
- Added additional handling for inheriting scenario identification.
@ssddanbrown
Refined design and text for entity permission changes
2570854
@ssddanbrown
Extracted entity perms. text to translation files
98c6422
@ssddanbrown
Updated entity perms. changes for dark mode support
7792da9
@ssddanbrown
Updated test for perms. changes and fixed static issues
bd412dd
@ssddanbrown
Fixed permission row permission check
6951aa3
@ssddanbrown ssddanbrown merged commit 22a91c9 into development Oct 14, 2022
@ssddanbrown ssddanbrown deleted the item_permission_revamp branch October 14, 2022 16:34
@ssddanbrown ssddanbrown mentioned this pull request Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ssddanbrown ssddanbrown

Labels
📖 Docs Update 💻 Front-End 🏭 Back-End 🛠️ Enhancement
Milestone
v22.10
Development

Successfully merging this pull request may close these issues.
1 participant
@ssddanbrown