Logical Theme System: Add event to register web routes

[ssddanbrown]

To allow easy registration of extra routes that require session and middlware.
Potentially have an option for registering auth routes? Maybe extra event or a passed parameter?

[ssddanbrown]

Added via 22a9cf1

[ssddanbrown]

Usage Example

<?php

use BookStack\Theming\ThemeEvents;
use BookStack\Facades\Theme;
use Illuminate\Routing\Router;

Theme::listen(ThemeEvents::ROUTES_REGISTER_WEB, function (Router $router) {

    $router->get('/counter', function () {
        $count = session()->get('counter', 0) + 1;
        session()->put('counter', $count);
        return "Count: {$count}";
    });
});

Theme::listen(ThemeEvents::ROUTES_REGISTER_WEB_AUTH, function (Router $router) {

    $router->get('/counter-auth', function () {
        $count = session()->get('secret-counter', 0) + 1;
        session()->put('secret-counter', $count);
        return "Count Authed: {$count}";
    });
});

[kekcsi]

Hello! Many thanks for this example because the bookstack web doesn't document this hack in detail. Unfortunately it wasn't enough for me to get it working. I am trying to add an endpoint to the API for programatic access. The browser session authenticates OK but when trying from curl command line, I keep getting Page expired 419 http responses. I am sending it the same token that I tested with built-in APIs like page listing e.g. That one accepted the token authentication http header, but not the cusom one created using the ROUTES_REGISTER_WEB_AUTH hook. What do you think went wrong? How can I debug?
By the way, I was expecting the ROUTES_REGISTER_WEB_AUTH router to create the endpoint with an /api path prefix but it's not the case.

[ssddanbrown]

@kekcsi Yeah, routes register this way won't have the ability to authenticate via the API, those theme events are just for web (within-UI) routes.

You could instead directly register the route like so (have not tested this, but think it should work) in your theme functions.php file:

<?php

use Illuminate\Support\Facades\Route;

Route::get('/api/hello', function () {
    return response()->json([
        'message' => 'hello!'
    ]);
})->middleware(['api']);

Otherwise feel free to also open a feature request for a ROUTES_REGISTER_API theme event.

[kekcsi]

@ssddanbrown thanks for the quick response, I tried the ->middleware(['api']) way and it works. You even have a session and endpoint will check the token. Great stuff! I'm not sure what benefits it would have if we had a theme event.