Skip to content

Address undesirable URLs being considered for back redirection #4656

@ssddanbrown

Description

@ssddanbrown

This is a specific problem in scenarios where the Referrer header is not present (browser settings or via Referrer-Policy header).
The app falls back to previous URL tracked in the session, but this may not reflect an actual user page.
An example of this is secure images. Also relevant is #4649.
This leads to users being redirected to odd endpoints in such scenarios.

We could potentially override session or redirect handling to not track undesireable URLs.
Alternatively, we could avoid using the in-built back redirection within BookStack for an alternative option. As an example, we could provide the redirect path within the request (some care to be taken here to prevent open redirection).

Potentially revert the changes in ea0469e once done to allow PWA manifest personalisation.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions