Invalid pluralisation for German translation of x_pages

[knuz92]

Describe the Bug

For chapters, the number of pages is displayed below. In the German version, the word "Seite" (page) is always displayed here and not "Seiten" (pages) if there are more than one.

Steps to Reproduce

Go to a book with chapters in it.

Expected Behaviour

the plural of "Seite" (page) is "Seiten" (pages)

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

BookStack v22.11.1

PHP Version

8.1

Hosting Environment

Debian 11

[ssddanbrown]

Hi @knuz92,
Just tested on my instance:

This seems to be correct?
Doesn't look like the translation has recently changed or anything, has been the same for the last 3 years.
Seems to be the same translation used in the sidebar.
Are you specifically looking at a different part of the interface? Or that shown in my screenshot?

[knuz92]

In your screenshot its correct, here you can see it live on my instance: https://rdmed.n.roteskreuz.at/books/test

[knuz92]

thats interesting - if you are not logged in, you get "Seiten" if i'm logged in i get "Seite" as in my Screenshot.

[knuz92]

It appears only on "Deutsch (Du)"

[ssddanbrown]

Thanks for the further investigation and information.

Can confirm this issue.
Tracing down how pluralisation works, we find this function is used to get the translation index:

https://github.com/laravel/framework/blob/d3ff07dbb343b7aaaef2cc623cc32516d8551a68/src/Illuminate/Translation/MessageSelector.php#L110

Since the informal German language has a somewhat custom local code in BookStack (de_informal) it does not match the list of hardcoded locales. Think we'll need to extend the MessageSelector here to match just against the first part of the locale, or add a specific case for de_informal.

[ssddanbrown]

This has now been addressed within 6070d80, with a test to cover, and will be part of the next feature release.

Thanks again @knuz92 for reporting.