[Bug Report]: PDF Generation - Images In Table Not Formatting Correctly

[zshannonmec]

Describe the Bug

Images that are added to tables within Bookstack pages seem to not size properly when exported as PDF. Instead of mirroring the HTML view the images are overlapping and giant in size making it illegible.

Steps to Reproduce

1. Create a table on a page
2. Insert pictures into table cells
3. Save page
4. Export page as PDF

Expected Behaviour

Pictures should be formatted in the same way they are in HTML.

Screenshots or Additional Context

I've attached two sample images. One of what it should look like (HTML/Editor) and what is produced by the export (PDF).

HTML / Editor Example

Export (PDF) Example

Exact BookStack Version

v21.12.2

PHP Version

7.4

Hosting Environment

Ubuntu 20.04.3 LTS - Installed using official installation script

[ssddanbrown]

Thanks for reporting @zshannonmec, Can confirm this issue.

The sizing of linked images within tables, for PDF export, is pretty complex. The cause of the images escaping the container were a side-effect of a patch to fix another image issue (#3120).

I've made some changes for the next patch release, in 8b5747e. These changes won't likely fix the issue though, but will instead probably cause images to be super small within their container which, although not ideal, is probably preferable since you could still click through and view and they won't be majorly overlapping.

I've tested the development branch of the DOMPDF library we use for PDF generation, and it appears the image sizing logic will soon be smarter to achieve the desired result. We just need to wait for their next stable release.

[zshannonmec]

Hi Dan,

Sounds great. I really appreciate you looking into this, and yes even as an interim solution, keeping the overall table/page formatting in tact is definitely preferable. 👍

[ssddanbrown]

I've now bumped our used version of DomPDF to the 1.2 which provides much better image-in-table support from my testing.
Will be part of the next feature release.