Bug: User's password validation rules mismatch across application

[jakubboucek]

Describe the bug
Password validation rules is mismatch across application.

Mismatch explain

CreateAdmin – 5 characters rule

In \BookStack\Console\Commands\CreateAdmin::handle() is validation rule for password only 5 chars length:

BookStack/app/Console/Commands/CreateAdmin.php

Lines 72 to 74 in 13c0386

	if (mb_strlen($password) < 5) {
	return $this->error('Invalid password provided, Must be at least 5 characters');
	}

RegisterController – 8 characters rule

In \BookStack\Http\Controllers\Auth\RegisterController::validator() is validation rule for password only 5 chars length:

BookStack/app/Http/Controllers/Auth/RegisterController.php

Lines 62 to 69 in e15fcf5

	protected function validator(array $data)
	{
	return Validator::make($data, [
	'name' => 'required|min:2|max:255',
	'email' => 'required|email|max:255|unique:users',
	'password' => 'required|min:8',
	]);
	}

l10n – 5, 6, 7, 8 characters rule description

Reqiurements for password is mismatched between languages in l10ns files.

Expected behavior
I expect keep requirements for same entity's property same across whole application.

Better way can be extract password validation to one helper.

Don't worry be happy
I am offering to help you with reunite it by Pull Request, just help me confirm the 8 character length is currently valid length for Users passwords in application.

[ssddanbrown]

Hi @jakubboucek,
Thanks for offering a pull request.

Yeah, 8 characters if currently the valid length.

[ssddanbrown]

Thanks again for reporting @jakubboucek,
This has been addressed in bb9cd9d to be part of the next feature release.