Conversation
2 new labels are added to the metrics: cloud_scanner_version and boaviztapi_version.
|
I was picturing more something like assuming of course that the values can be strings. Attaching this info to every single metric generated is useful only if you want to filter based on them. I suppose if you had several instances of CS storing into Prometheus at the same time then that could be relevant. Is that the idea? You could then compare the results for different versions of the API for instance. |
|
I fully agree on the principle but I think that OpenMetrics / Prometheus metrics format only support numerical values (not string). Yes the general idea behind this PR is to provide info to end user in the context of where we collects data during a long time span. In this case we may collect metrics that span several versions of API and as we have seen the values returned for the same resource may evolved with new API version. This can help identify the reason for a change in value. |
|
I think you are right about the values being numerical only Let's go for what you suggested |
Two new labels are added to all the metrics:
cloud_scanner_versionandboaviztapi_version.Per example: