Skip to content

Footer icon improvements #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vivekgh0sh
Copy link

Made some improvements in footer icons as follows:

  • discord - fixed the hover over the discord icon issue where it doesn't change color on hover.
  • github, nostr, youtube, bitcoin tv - fixed the default grey icon and resized to match other logos
  • x - changed the twitter logo to x logo
  • bitcoin tv - made the bitcoin tv svg to match the current logo

Here's a quick comparison:
Screenshot from 2025-07-20 18-14-50
Screenshot from 2025-07-20 18-14-42

Docker: removed the version from docker-compose.yml as compose file versions have been deprecated and included a --watch flag to live update changes.

Copy link

netlify bot commented Jul 20, 2025

Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit 45a3e90
🔍 Latest deploy log https://app.netlify.com/projects/bitcoin-design-site/deploys/687cf379e916f80008c57aab
😎 Deploy Preview https://deploy-preview-1186--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vivekgh0sh vivekgh0sh marked this pull request as draft July 20, 2025 13:45
@vivekgh0sh vivekgh0sh marked this pull request as ready for review July 20, 2025 13:48
Copy link
Collaborator

@swedishfrenchpress swedishfrenchpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but I'm unsure about the docker-compose.yml changes. Holding off on explicit approval until we have another set of eyes on it. @GBKS Do you have any thoughts on those changes? Safe?

Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR. Some feedback:

  1. That some of the icons look grey is intentional, those are links you have visited before. This was introduced in #1085 based on usability feedback we received. We should keep this logic as-is. But we can remove the .username rule in that CSS as it does not do anything.
  2. Fixing the Discord logo is a good improvement. It's unnecessarily complex with the clipping path, and the the fill in the SVG breaks the hover state.
  3. Maybe it is time to update to the X logo, despite it being super ugly and there never being an official rebranding. Rest in peace, little blue bird.
  4. The BitcoinTV logo was intentionally simplified, because the original one looks ugly at that scale and does not fit in with the rest. It's been years since we posted to BitcoinTV, maybe there's a discussion to be had whether we even want to include it?
  5. The logos in the after screenshot are not visually balanced, some are bigger than others. Let's keep that balance.
  6. No docker compose updates in this PR please. That is something that affects the dev workflow and should be treated separately with proper testing by others.

Sorry, quite a bit of feedback on this seemingly simple change. Hope it all makes sense.

@vivekgh0sh
Copy link
Author

Thanks for the detailed feedback. I should've discussed first before making these changes.

  1. Yes I noticed the links you've visited being greyed out function now, I got confused with the discord logo and twitter logo because in the local build those link checker function were not working.
  2. I am thinking of resizing the discord and X logo to match the current scale of other logos.
  3. It's X - the everything app now.
  4. Agree with the BitcoinTV logo being the misfit, even now it doesn't look aligned.
  5. Agreed
  6. Yes sorry I should have asked before sending the compose changes.

Should I go ahead and make changes to the Discord and X logos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants