-
Notifications
You must be signed in to change notification settings - Fork 112
Footer icon improvements #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Footer icon improvements #1186
Conversation
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM but I'm unsure about the docker-compose.yml changes. Holding off on explicit approval until we have another set of eyes on it. @GBKS Do you have any thoughts on those changes? Safe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR. Some feedback:
- That some of the icons look grey is intentional, those are links you have visited before. This was introduced in #1085 based on usability feedback we received. We should keep this logic as-is. But we can remove the
.username
rule in that CSS as it does not do anything. - Fixing the Discord logo is a good improvement. It's unnecessarily complex with the clipping path, and the the fill in the SVG breaks the hover state.
- Maybe it is time to update to the X logo, despite it being super ugly and there never being an official rebranding. Rest in peace, little blue bird.
- The BitcoinTV logo was intentionally simplified, because the original one looks ugly at that scale and does not fit in with the rest. It's been years since we posted to BitcoinTV, maybe there's a discussion to be had whether we even want to include it?
- The logos in the after screenshot are not visually balanced, some are bigger than others. Let's keep that balance.
- No docker compose updates in this PR please. That is something that affects the dev workflow and should be treated separately with proper testing by others.
Sorry, quite a bit of feedback on this seemingly simple change. Hope it all makes sense.
Thanks for the detailed feedback. I should've discussed first before making these changes.
Should I go ahead and make changes to the Discord and X logos? |
Made some improvements in footer icons as follows:
Here's a quick comparison:


Docker: removed the version from
docker-compose.yml
as compose file versions have been deprecated and included a --watch flag to live update changes.