feat: pass bip32PathsAbsolute flag into bip174 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkaplanbitgo
force-pushed
the
BG-54756-pass-in-bip32-decoding-flag-into-bip174
branch
from
00abbb7 to
e70ce0c
Compare
|
@ericcrosson-bitgo - want your review to make sure that the |
davidkaplanbitgo
force-pushed
the
BG-54756-pass-in-bip32-decoding-flag-into-bip174
branch
from
e70ce0c to
677dfdb
Compare
davidkaplanbitgo
force-pushed
the
BG-54756-pass-in-bip32-decoding-flag-into-bip174
branch
from
677dfdb to
4a88a1e
Compare
davidkaplanbitgo
changed the title
| "version": "npm:@bitgo/[email protected]", | ||
| "resolved": "https://registry.npmjs.org/@bitgo/bip174/-/bip174-3.0.0.tgz", | ||
| "integrity": "sha512-Qv98vy6l1WgZwrxKx7IPYY91/+Z3tpALVSDn+Ic9qCsxygCq9gYw5eL8q3kd7LYTFLy/HgcqhcMOa83Spbp4JA==" | ||
| "version": "npm:@bitgo-forks/[email protected]", |
There was a problem hiding this comment.
I thought this was gonna be -master.1?
There was a problem hiding this comment.
There are 2 identical versions: 3.0.0-rc.1, which I published manually, and 3.1.0-master.1, which semantic-release published when the release pipeline was turned on
https://www.npmjs.com/package/@bitgo-forks/bip174?activeTab=versions
brandonblack
approved these changes
Jan 24, 2023
ericcrosson-bitgo
approved these changes
Jan 24, 2023
ericcrosson-bitgo
deleted the
BG-54756-pass-in-bip32-decoding-flag-into-bip174
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bip174bip32PathsAbsoluteflag for PSBT deserializationBG-54756