feat(psbt): use bigint values #39
Conversation
brandonblack
force-pushed
the
bigint_psbt
branch
from
12a8b80 to
de8e9ce
Compare
| this.data.inputs, | ||
| this.__CACHE, | ||
| )!; | ||
| return Number( |
There was a problem hiding this comment.
Should the fee rate just be a bigint as well? It looks like this was already being floored to an integer, and it seems like the arithmetic would be simpler if it were all bigint since this would have to get cast back to bigint before it is multiplied by the tx size, which it looks like we're already doing in this PR.
There was a problem hiding this comment.
@davidkaplanbitgo noticed that in the Doge team's changes to transaction builder, they treat fee rates as number, so we were inclined to follow that pattern. I admit to being a bit torn about it.
There was a problem hiding this comment.
Gonna leave a mental bookmark on this as we proceed with psbt/bigint-onlyifying things, and if it turns out to make more sense to make this a bigint too, we'll change it.
Issue: BG-56116