feat(sdk-core): optimize bulk accept share with adaptive batching #6707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the bulk accept share request implementation by replacing the inefficient payload size calculation approach with smart adaptive batching that automatically discovers optimal batch sizes per coin type.
Context
The original PR (#6688) addressed the issue CSI-889 where users were getting 413 "Request Entity Too Large" errors when bulk accepting many wallet shares (78 in the reported case). However, the implementation had several inefficiencies:
Solution
This optimization implements an intelligent adaptive batching algorithm:
Key Benefits
Testing
The existing tests should continue to pass as the external behavior remains the same - just more efficient internally.
Related