feat(root): address ws vulnerability #6265
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its primarily a concern for backend services, however bitgo express does not directly use the ws package. |
pranavjain97
approved these changes
Jun 10, 2025
margueriteblair
approved these changes
Jun 10, 2025
lokesh-bitgo
approved these changes
Jun 10, 2025
| resolved "https://registry.npmjs.org/ws/-/ws-7.4.6.tgz#5654ca8ecdeee47c33a9a4bf6d28e2be2980377c" | ||
| integrity sha512-YmhHDO4MzaDLB+M9ym/mDA5z0naX8j7SIlT8f8z+I0VtzsRbekxEutHSme7NPS2qE8StCYQNUnfWdXta/Yu85A== | ||
| [email protected], [email protected], ws@^3.0.0, ws@^5.2.4: | ||
| version "5.2.4" |
There was a problem hiding this comment.
Are we locking the ws version to 5.2.4? Some dependent packages require [email protected], but this change forces them to use 5.2.4, which might not support features introduced in the newer versions. Could this lead to runtime issues or missing functionality?
There was a problem hiding this comment.
Good point, we probably shouldn't force the resolution for higher versions. I'll investigate what nested dep caused this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ws vulnerability does not affect bitgojs, however it
is a cause of alarm when viewing the audit report for this repo.
Unfortunately the vulnerability comes from a deep nested dependency with celo,
where even upgrading to the latest celo deps will not fix the issue.
This PR creates a resolution for "ws" to address the audit.