fixing the route_parameter value null bug #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r key and value , if key is set and value was then , code was breaking , so i fixed that, now if key is set but value is null, then # will be route
Biostate
requested changes
Aug 21, 2025
Comment on lines
+94
to
+96
| if ($this->type === 'link') { | ||
| return $this->url ?: '#'; | ||
| } |
There was a problem hiding this comment.
If type is link, then it should use $this->resolveUrl() to resolve the URL.
Comment on lines
+98
to
+120
| if ($this->type === 'route' && $this->route) { | ||
| try { | ||
| $parameters = is_array($this->route_parameters) ? $this->route_parameters : []; | ||
| $route = app('router')->getRoutes()->getByName($this->route); | ||
| if ($route) { | ||
| $uri = $route->uri(); | ||
| preg_match_all('/\{(\w+?)\}/', $uri, $matches); | ||
| $requiredParameters = $matches[1]; | ||
| foreach ($requiredParameters as $param) { | ||
| if (!isset($parameters[$param]) || is_null($parameters[$param]) || trim($parameters[$param]) === '') { | ||
|
|
||
| return '#'; | ||
| } | ||
| } | ||
| return route($this->route, $parameters); | ||
| } | ||
| return '#'; | ||
| } catch (\Illuminate\Routing\Exceptions\UrlGenerationException $e) { | ||
|
|
||
| return '#'; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I’m not sure if this is the most viable solution for the problem. I believe there might be a simpler approach.
|
Thanks for the PR; I really appreciate it. Can you fix the 2 requested changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing the route_parameter value null bug , In route parameter for url type = route, if key is set and value was null then , code was breaking , so i fixed it, now if key is set but value is null, then # will be route