chore: Modernize the test suite#84
Merged
Merged
Conversation
rzane
force-pushed
the
rzane/modernize-tests
branch
from
dcf8522 to
54659b2
Compare
samandmoore
approved these changes
Dec 31, 2025
| const visitor = createVisitor(); | ||
|
|
||
| expect(() => { | ||
| new ABConfiguration({ splitName: 'button_color', visitor: visitor }); |
Member
There was a problem hiding this comment.
is this missing the comment for ts-expect-error?
Contributor
Author
There was a problem hiding this comment.
I think the types are just wrong here. We should get rid of all of these tests and all of the validations in the constructor. This is all private, so we're effectively validating that our own code doesn't have bugs, and typescript already does that for us in this regard.
| splitName: 'element', | ||
| trueVariant: 'water', | ||
| visitor: testContext.visitor | ||
| visitor: visitor |
Member
There was a problem hiding this comment.
could also use just visitor here like you do below. surprised we don't lint or format into a single approach.
also fine to leave it for now
Contributor
Author
There was a problem hiding this comment.
Yeah, we need to tighten up the linting here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the test suite in preparation for some larger refactors. I'm not touching any source files or build processes in this PR.
axios-mock-adapterwith MSW, which will make it easier to remove AxiostestContextpattern.