Skip to content

updates to fix some security vulns#58

Merged
HipsterBrown merged 3 commits into
masterfrom
sam-updates
Jul 19, 2023
Merged

updates to fix some security vulns#58
HipsterBrown merged 3 commits into
masterfrom
sam-updates

Conversation

@samandmoore

@samandmoore samandmoore commented Jul 18, 2023

Copy link
Copy Markdown
Member

this updates jest and release-it to fix some but not all of the critical security vulns.

at least some of them still can't be upgraded because of release-it not having a new enough version that works with the patched dependency versions.

@HipsterBrown HipsterBrown left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DomainLGTM

Comment thread package.json
"@rollup/plugin-typescript": "^5.0.2",
"@types/blueimp-md5": "^2.7.0",
"@types/js-cookie": "^2.2.4",
"@types/node": "^16.18.38",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensuring this matches the version of node used by this project.

Comment thread tsconfig.json
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"moduleResolution": "node",
"skipLibCheck": true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignores type checking dependencies. https://www.typescriptlang.org/tsconfig#skipLibCheck

@HipsterBrown HipsterBrown left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PlatformLGTM

@HipsterBrown HipsterBrown merged commit 0289df6 into master Jul 19, 2023
@HipsterBrown HipsterBrown deleted the sam-updates branch July 19, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants