fix(braintrust): pass span_attributes in async logging and skip tags on non-root spans #18409
+29
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in the Braintrust logger:
async_log_success_eventdid not passspan_attributesThe sync version (
log_success_event) did pass customspan_attributes, but the async version did not.This caused span metadata to be lost when using async logging.
tagsshould not be sent for non-root spansBraintrust returns an error when
tagsare set on non-root spans:Braintrust cannot specify 'tags' for non-root spans.This PR only includes
tagswhenroot_span_idis not present.Docs: https://docs.litellm.ai/docs/observability/braintrust
Changes
span_attributesinasync_log_success_event.tagsfor root spans.