fix: vertex binary issue #18343
Open
fix: vertex binary issue #18343
+62
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent' instead of 'data' for httpx compatibility [agent]
…seLLMHTTPHandler - Implemented tests to ensure that the async_create_file and create_file methods correctly handle binary data without raising UnicodeDecodeError. - Verified that the original binary content is passed directly to the httpx client without modification. - Added regression tests for issues related to uploading binary files to Vertex AI. [agent]
- Eliminated the synchronous test for create_file that handled binary data, as it was redundant with the existing async test. - Cleaned up the test file by removing unnecessary imports and comments.f [agent]
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
- Removed redundant comments regarding HTTPX data handling in the file upload methods. - Streamlined the code for better readability while maintaining functionality. [agent]
- Added detailed comments to clarify the mocking of binary content, provider configuration, logging, and HTTP response in the async_create_file test. - Verified that binary content is passed directly to the HTTP client without modification, ensuring robust handling of invalid UTF-8 bytes. [agent]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issues
Fixes binary file upload to Vertex AI (UnicodeDecodeError when uploading PDFs/images)
Pre-Submission checklist
tests/litellm/directorymake test-unitType
🐛 Bug Fix
Changes
Fixed
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xffwhen uploading binary files (PDFs, images) to Vertex AI via the/filesendpoint.Root cause: The file upload handler was calling
.decode("utf-8")on binary file content before sending to httpx, which fails for non-UTF-8 binary data.Fix:
.decode("utf-8")call - httpx accepts bytes directlydata=tocontent=- the correct httpx parameter for raw body contentcreate_file) and async (async_create_file) code paths