Fixes per review for service recording and display info #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelOrlov
commented
Dec 10, 2023
MichaelOrlov
commented
- Relates Implement service recording and display info about recorded services ros2/rosbag2#1480
Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Michael Orlov <[email protected]>
- Delete "rosbag2_transport/qos.cpp" which was moved to the rosbag2_storage package during prior PR before rebase Signed-off-by: Michael Orlov <[email protected]>
Author
|
cc: @Barry-Xu-2018 |
Owner
|
Thanks for your help. |
Barry-Xu-2018
merged commit 5cca0f5
into
Barry-Xu-2018:review/rosbag2_service_record_and_show
Barry-Xu-2018
added a commit
that referenced
this pull request
Dec 11, 2023
Fixes per review for service recording and display info Signed-off-by: Barry Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.