-
Notifications
You must be signed in to change notification settings - Fork 0
Fixes for tests in service recording #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for tests in service recording #1
Conversation
- Got rid form ambient sleep for waiting for messages to be recorded - Exclude "/rosout" topic from recording Signed-off-by: Michael Orlov <[email protected]>
- Also add default timeout parameter for ClientManager::send_request(..) Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Michael Orlov <[email protected]>
- Also parameterize tests to use default supported storage plugins Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Michael Orlov <[email protected]>
- Rationale: Deprecation of the rcpputils::fs in future See ros2/rcpputils#164 for details Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Michael Orlov <[email protected]>
|
@Barry-Xu-2018 Please review and merge to your branch if you have no concerns or requests for changes. |
|
Thank you for your assistance. |
|
I merged them.
If you think it is okay, I will add it in ros2#1480. |
759064c
into
Barry-Xu-2018:review/rosbag2_service_record_and_show
|
Sorry for my late response. Yeah, with warning will be even better. 👍 |
List of fixes:
std::filesysteminstead ofrcpputils::fsfunctionsSee Deprecate
rcpputils::fsin favor of C++17std::filesystemros2/rcpputils#164 for detailsros2 bag infoverb with--verbose--verboseparameter