Skip to content

Inspector V2: SkyMaterial, AbstractMesh Occlusions, AbstractMesh Edge Rendering #16951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 5, 2025

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Aug 4, 2025

Sky material:
image

Abstract Mesh:

image

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16951/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16951/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16951/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16951/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16951/merge/?snapshot=refs/pull/16951/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

@CedricGuillemet CedricGuillemet marked this pull request as ready for review August 4, 2025 17:10
@CedricGuillemet CedricGuillemet changed the title Inspector V2: SkyMaterial Inspector V2: SkyMaterial, AbstractMesh Occlusions, AbstractMesh Edge Rendering Aug 4, 2025
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16951/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16951/merge/?snapshot=refs/pull/16951/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16951/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2025

@deltakosh deltakosh enabled auto-merge (squash) August 4, 2025 22:53
… cgMuster2

# Conflicts:
#	packages/dev/inspector-v2/src/components/properties/nodes/abstractMeshProperties.tsx
#	packages/dev/inspector-v2/src/services/panes/properties/materialPropertiesService.tsx
#	packages/dev/inspector-v2/src/services/panes/properties/nodePropertiesService.tsx
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 5, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16951/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 5, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16951/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16951/merge/?snapshot=refs/pull/16951/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 5, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 5, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 5, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 5, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 5, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 5, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16951/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16951/merge/?snapshot=refs/pull/16951/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 5, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16951/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 5, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 5, 2025

@deltakosh deltakosh merged commit 2275338 into BabylonJS:master Aug 5, 2025
20 checks passed
VicenteCartas pushed a commit to VicenteCartas/Babylon.js that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants